Replace usages of j and js quoted strings with ones without id
#479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Closing this as not necessary anymore, see ml-in-barcelona/server-reason-react#139 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ml-in-barcelona/server-reason-react#139, server-reason-react is starting to fail if it finds
jorjsin quoted strings for code that usesmelange.ppx.Using that patch, I noticed some of the code in styled-ppx was using these quoted strings, but there's no unicode or any interpolation, so it can just use quoted strings without id
{||}.The diff is long, but the process was mostly find and replace on the affected files, nothing else. I originally started using regular strings, but found a few places where double quotes are used, so I feel safer by keeping the same literals without having to escape.