Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gromet_FN_v0.1.5.yaml is not validating #39

Closed
kwalcock opened this issue Nov 14, 2022 · 1 comment
Closed

gromet_FN_v0.1.5.yaml is not validating #39

kwalcock opened this issue Nov 14, 2022 · 1 comment

Comments

@kwalcock
Copy link
Contributor

No description provided.

@cl4yton
Copy link
Contributor

cl4yton commented Nov 14, 2022

Good catch @kwalcock , that was indeed a bug! I believe I have fixed it (it was in the GrometPort default_value property (which is a reference, but I had mistakenly put the reference under a type specifier. The file now appears valid (acc'd to https://editor.swagger.io/).

background FYI: this aspect of automates/skema (in the automates-v2 repo) is being "developed" by me, and I'm directly committing to master (which is undesirable in the long run) -- this has been for expediency. Shortly I hope to move this to a proper PR-review scheme, and I'd like to discuss with you all (@adarshp @titomeister @vincentraymond-ua @kwalcock ) perhaps moving this to the skema repo.

For now, I believe this is fixed, so closing.

@cl4yton cl4yton closed this as completed Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants