Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python issues in extractions.py #6

Open
skdebray opened this issue Jul 20, 2023 · 0 comments
Open

Python issues in extractions.py #6

skdebray opened this issue Jul 20, 2023 · 0 comments
Assignees

Comments

@skdebray
Copy link

The are a couple of minor Python issues in file extractions.py in the branch design-attempt-01 that should be fixed before we merge everything into main:

  • I'd like to try and stay with the style guidelines in PEP-8 (https://peps.python.org/pep-0008/). One of the guidelines is that lines of code are at most 79 characters long. This file has a few lines longer than that, these need to be fixed. This tool may be helpful for this: https://github.com/astral-sh/ruff
  • It would be helpful to have some documentation at the top indicating the purpose of this code and also how it should be invoked.
  • For each of the classes defined in this file, some documentation indicating what it's for and where+how it will be used.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants