-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p5.js web editor examples #892
Comments
Ack, this might not be as easy as I thought! I got a weird error when trying to run "image classification" in the p5.js web editor. Something to do with the way the web editor deals with images (sending everything to AWS) and the way deeplearn.js makes everything a WEBGL texture? |
An update on this: Here's an image classification example: https://alpha.editor.p5js.org/cvalenzuela/sketches/S19HhmQe7 The error @shiffman was getting was because the editor uploads it's own versions of the image to a aws bucket = CORS error. So you need to create images with Where should we start putting this? |
Related to ml5js/ml5-examples#7, we should probably use |
Oh, let's also create an ml5 web editor account, this way people can also go to: https://alpha.editor.p5js.org/ml5/sketches/ I'll do that right now and e-mail the password. |
I'm having the same CORS issue when trying to make a chrome extension which can scrape images from any website and load its pixels using |
@oveddan, have you tried adding @shiffman, I tried |
I just added Image Classification Transfer Learning: https://alpha.editor.p5js.org/ml5/sketches/rJUUMENxX |
Examples like LSTM and Style Transfer need a model folder, but p5 web editor doesn't allow me to upload files in special format. (Files like this: https://github.com/ml5js/ml5-examples/tree/master/p5js/StyleTransfer_Image/models/wave) And for word2vec example, two of the json files are too large to be uploaded. I think we need to host all those files remotely if we want to port these examples in p5 web editor. |
I'll check in with the p5 web editor team re: model files. For word2vec what if we link to the raw github file? At this point I think it's ok to skip any examples that don't immediately translate well to the web editor. |
I'm running into the same issue as @yining1023 with the Crepe examples. The model files cannot be uploaded to the editor. File type not supported. |
Just sent a pull request to add the YOLO and PoseNet examples to the examples readme. I had some trouble getting the YOLO example to work because of a CORS issue. Once I deleted and started from scratch with HTTPS, everything ran smoothly. |
@shiffman pulling the Word2Vec raw data files directly from Github seems to work. Would these examples ideally not use any HTML at all? Specifically wondering if I should recreate the Word2Vec html using P5 DOM library? |
For anyone tracking this, you can see all the ml5 web editor examples here: https://editor.p5js.org/ml5/sketches Where should links to these go? In |
Hi all - I'm also struggling with the same CORS error, both using the p5 Web Editor and on Glitch. I've tried using the It also looks like the example for image classification on the p5 editor account for ml5 is also facing the same error (see below). Anyone else found a workaround for this? |
@shiffman - just FYI, I will be working on automating the ml5 examples upload to the p5 web editor here - https://github.com/joeyklee/p5.js-web-editor/tree/fetch-ml5-examples - and will coordinate with @catarak regarding the script :) I'll keep you posted about developments. |
@joeyklee great, keep me updated! let me know if there's anything i can do to get the ml5 examples working with the web editor. |
Thanks @catarak! I'll hopefully have something in working order in the next couple hours and I'll check in :) Thank you! |
Rather than adding an image to index.html, we could also set the crossorigin attribute to the created image in this way.
Hence the code of the example will become:
|
let me know anytime y'all want me to re-run the script to import the ml5 examples into the web editor! |
@shiffman , I'd like to work on this issue. It'd be really appreciable if you can guide me how do I proceed to work on this since it's my first issue. |
Hi @zoyron - I believe this issue is more or less resolved already with ml5js/ml5-examples#227. I've left this issue open so that when the p5 web editor public API is launched we remember to change the If you're still interested in addressing other issues in this repo, we'd appreciate your contribution! |
Hi All. This should be resolved now. With the upcoming P5 web editor API this will be much simpler to handle. For now, we work with @catarak who helps to deploy our examples updates. Thank you! |
Moving #23 to here. Would be great to have the p5 examples all running in the web editor. These can be linked from README's associated with each example as well as from the website.
The text was updated successfully, but these errors were encountered: