Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stingy algorithm returning unthinned datasets #9

Closed
mlammens opened this issue Aug 4, 2015 · 3 comments
Closed

Stingy algorithm returning unthinned datasets #9

mlammens opened this issue Aug 4, 2015 · 3 comments

Comments

@mlammens
Copy link
Owner

mlammens commented Aug 4, 2015

@paleo13 I'm testing out the latest pull request. When I run the stingy algorithm the "best thinned dataset" returned has 201 locations - that is, none were removed. When I used the lp_solve method, the "best thinned dataset" contains 123 records. Neither of these match what the original thin algorithm produced or the "by hand" method yielded. Any idea what's going wrong?

@jeffreyhanson
Copy link
Contributor

Regarding lp_solve was this when using code in the vignette or running it using other code? If using the vignette, I set a timeout of 10 seconds, because lp_solve generally takes 10 minutes to run for the built-in dataset. So the solution returned in the vignette is extremely unlikely to be optimal.

Not sure what's going wrong with the stingy aglorithm, I'll take a look this afternoon and get back to you.

@mlammens
Copy link
Owner Author

mlammens commented Aug 5, 2015

That's right, I was using the code in the vignette. If you run lp_solve for longer, do you get to the optimal solution? Also, then we should emphasize that it needs to run longer to achieve the optimal solution.

@mlammens
Copy link
Owner Author

Fixed with most recent changes by @paleo13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants