Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gameday UI improvements #9

Closed
2 of 4 tasks
andschneider opened this issue May 31, 2021 · 1 comment · Fixed by #22
Closed
2 of 4 tasks

Gameday UI improvements #9

andschneider opened this issue May 31, 2021 · 1 comment · Fixed by #22
Assignees
Labels
enhancement New feature or request

Comments

@andschneider
Copy link
Collaborator

andschneider commented May 31, 2021

After PR #8 most of the major UI components are done. There are a few outstanding things I would like to dial though.

help

When the terminal height is small the help messages get cut off.

  • Fix help popup. Maybe display as multiple columns.

image

strike zone

The strike zone gets distorted when the info or box score panes aren't shown.

  • Constrain width for strike zone and pitch display

bad:
image
good:
image

box score

See images

  • Add pitching information to boxscore

image

  • Display batter substitutions

image

@andschneider andschneider added the enhancement New feature or request label May 31, 2021
@andschneider andschneider self-assigned this May 31, 2021
@andschneider
Copy link
Collaborator Author

Box score:

For the player names I'm using the last string after splitting by white space. This leads to some wrong results, e.g. Fernando Tatis Jr. becomes Jr..

  • Fix player names

@andschneider andschneider added this to the v0.1.0 release milestone Jun 9, 2021
This was referenced Jun 29, 2021
@andschneider andschneider linked a pull request Jun 29, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant