Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformer compliance logging #158

Merged
merged 1 commit into from
Oct 19, 2018

Conversation

xyhuang
Copy link
Contributor

@xyhuang xyhuang commented Oct 13, 2018

This adds compliance logging to transformer.

@robieta
Copy link
Contributor

robieta commented Oct 15, 2018

One thing to note is that #153 pulled in nearly all of the changes to the compliance/ dir (except for making the timestamp report decimals). So you may find it easier to branch from mlperf/training HEAD rather than the ResNet PR branch to avoid lots of extraneous files in your PR. Or if its easier feel free to leave it as is since a lot of it will simplify once the ResNet PR is merged.

@xyhuang
Copy link
Contributor Author

xyhuang commented Oct 15, 2018

thanks, I will rebase to 153.

@xyhuang xyhuang force-pushed the transformer_logging branch 2 times, most recently from 19e30c2 to 4c24016 Compare October 15, 2018 22:55
@xyhuang xyhuang changed the title [WIP] Transformer compliance logging Transformer compliance logging Oct 15, 2018
@xyhuang xyhuang force-pushed the transformer_logging branch 3 times, most recently from 0674c6b to 656cd9c Compare October 19, 2018 16:01
- Add compliance logging for transformer
- Modify run_and_time.sh to install mlperf_compliance package
- Fix readme issues and modify run command for compliance logging
@xyhuang
Copy link
Contributor Author

xyhuang commented Oct 19, 2018

Hi @robieta I think this is ready for review. Please let me know if i missed anything. Thanks!

Copy link
Contributor

@robieta robieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@robieta robieta merged commit aefeaac into mlcommons:master Oct 19, 2018
ekrimer pushed a commit to ekrimer/training that referenced this pull request Oct 10, 2019
- Add compliance logging for transformer
- Modify run_and_time.sh to install mlperf_compliance package
- Fix readme issues and modify run command for compliance logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants