Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about the PRelu & LeakyRelu improvement #50

Closed
weizmann opened this issue Apr 24, 2023 · 2 comments
Closed

about the PRelu & LeakyRelu improvement #50

weizmann opened this issue Apr 24, 2023 · 2 comments

Comments

@weizmann
Copy link

weizmann commented Apr 24, 2023

Thanks for your great work!

I have used the original wav2lip model to process wild video dubbing, and found there will be some abnormal color in the mouth occasional.

I think the reason is the original wav2lip model lacks proper softmax/relu process when handling color generation.

I read from your README and found that the 288x288 model used more powerful ReLU to process the convnet.

I have 2 questions about the improvement:
Q1: Why did you choose to update the PRelu & LeakyRelu? can you give me some typical scenarios when PRelu/LeakyRelu works better?
Q2: Will 288x288 model eliminates the abnormal color in the mouth?

Some bad cases in original Wav2Lip model:

image

image

image

@weizmann weizmann changed the title will 288x288 model eliminates the abnormal color in the mouth about the PRelu & LeakyRelu improvement Apr 24, 2023
@weizmann
Copy link
Author

It will be better to give us some effect comparison videos ☺️

@ghost
Copy link

ghost commented Apr 24, 2023

q1: I chosen these activations because I rearange of scale, [-1,1] instead of [0,1] by following: https://github.com/soumith/ganhacks
q2: wav2lip 288x288 is just the upscale version of the original for the better resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant