Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User profile posts not showing #738

Closed
Sjmarf opened this issue Oct 31, 2023 · 5 comments · Fixed by #739
Closed

User profile posts not showing #738

Sjmarf opened this issue Oct 31, 2023 · 5 comments · Fixed by #739
Assignees
Labels
bug Something isn't working

Comments

@Sjmarf
Copy link
Contributor

Sjmarf commented Oct 31, 2023

Posts don't show on the user profile, only comments. This needs to be fixed before next TF

@Sjmarf Sjmarf added the bug Something isn't working label Oct 31, 2023
@boscojwho
Copy link
Contributor

What's the repro for this/which build? I see my posts on my build.
There was a similar bug a few weeks back, but that got fixed...unless that fix didn't address all the causes?

@boscojwho
Copy link
Contributor

Looks like this commit introduced bug: 1eeef50

@boscojwho
Copy link
Contributor

boscojwho commented Nov 1, 2023

Looks like posts tracker does have the actual posts, but the filter function is filtering out everything in the return $0.commentView.creator.id == userID block:

  • I don't see any recent changes to this logic, so probably something in the model/middleware layer is causing this?
Screenshot 2023-10-31 at 5 36 05 PM

@boscojwho
Copy link
Contributor

Looking into whether changes in UserModel caused this issue.

@boscojwho
Copy link
Contributor

boscojwho commented Nov 1, 2023

@Sjmarf
Ok, bug is fixed if we replace:
return $0.creator.id == userID (new middleware)
with:
return $0.creator.person.id == userID (calls deprecated person)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants