Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mljar model class #21

Closed
maksymiuks opened this issue Aug 21, 2019 · 3 comments
Closed

mljar model class #21

maksymiuks opened this issue Aug 21, 2019 · 3 comments

Comments

@maksymiuks
Copy link
Contributor

First of all, very nice api, I love to use it.

But I have one small problem. Can You please change class of object returned by mljar_fit to something that will stright away indicate on mljar? Right now it is simple list and it is hard for me to check if given model is indeed mljar model.
@pplonski
Copy link
Contributor

Thanks! Can you suggest the solution?

maksymiuks added a commit to maksymiuks/mljar-api-R that referenced this issue Aug 21, 2019
@maksymiuks
Proposed solution for Issue mljar#21
4655778
@maksymiuks
Copy link
Contributor Author

PR ready

@maksymiuks
Copy link
Contributor Author

Also. Is it possbile for that list to contain not only field with experiment title but with project title aswell?

pplonski added a commit that referenced this issue Aug 21, 2019
@pplonski
Merge pull request #22 from maksymiuks/patch-1
242acc4 
Proposed solution for Issue #21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pplonski @maksymiuks