Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

number of components ? #12

Closed
jajoe opened this issue Jul 20, 2017 · 4 comments
Closed

number of components ? #12

jajoe opened this issue Jul 20, 2017 · 4 comments

Comments

@jajoe
Copy link
Member

jajoe commented Jul 20, 2017

I don't understand... we don't choose the number of components of our PCA ?
See how we do with SKlearn :
http://scikit-learn.org/stable/modules/generated/sklearn.decomposition.PCA.html

A PCA enables dimensionality reduction, so we have to choose our new dimensionality.

@targos
Copy link
Member

targos commented Jul 20, 2017

What don't you understand? The current behavior is the same as the default from SKlearn (keep all components).
We can add options to configure that for sure.

@jajoe
Copy link
Member Author

jajoe commented Jul 20, 2017

The main goal of PCA is to reduct dimensionality, so if we keep every components I'm not sure that a PCA is useful.
I'll add that tomorrow, I believe it just needs to apply that at the end of the function predict().

@targos
Copy link
Member

targos commented Jul 20, 2017

We can talk about it tomorrow

@targos
Copy link
Member

targos commented Jul 25, 2017

nComponents option has been added to the predict method

@targos targos closed this as completed Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants