fix: bug in OPLS predict method + testcase #25
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
==========================================
+ Coverage 94.51% 95.78% +1.26%
==========================================
Files 6 6
Lines 529 546 +17
Branches 62 80 +18
==========================================
+ Hits 500 523 +23
+ Misses 28 23 -5
+ Partials 1 0 -1
Continue to review full report at Codecov.
|
| features.scale('column', { scale: this.stdevs }); | ||
| if (labels.rows > 0 && this.mode === 'regression') { |
There was a problem hiding this comment.
why aren't you scaling the labels on regression's mode?
There was a problem hiding this comment.
Indeed I'm doing it (between lines 341 and 343). But this if in those lines are because the labels are optional (if you know which class the sample belongs) in order to calculate statistical parameters Q2y and AUC and that's the bug that I want to fix, some cases I want to test a sample without knowing which class belongs, and that's not currently working.
src/OPLS.js
Outdated
| @@ -313,35 +313,40 @@ export class OPLS { | |||
| * @param {Number} [options.nc] - the number of components to be used | |||
| * @return {Object} - predictions | |||
| */ | |||
| predict(newData, options = {}) { | |||
| const { trueLabels = [] } = options; | |||
| predict(data, options = {}) { | |||
There was a problem hiding this comment.
Please could you is jsdoc:
- specify that [options={}]
- use the same name in the method as in the jsdoc (so either data or features)
src/OPLS.js
Outdated
| } | ||
|
|
||
| const features = new Matrix(newData); | ||
| const features = new Matrix(data); |
There was a problem hiding this comment.
for me in the call of the method you may replace data by features and just specify features = new Matrix(features) to ensure it is a Matrix
No description provided.