Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdaBelief - Adapting Stepsizes by the Belief in Observed Gradients #233

Merged
merged 12 commits into from
Feb 19, 2022

Conversation

zoq
Copy link
Member

@zoq zoq commented Oct 21, 2020

Implementation of AdaBelief - "AdaBelief Optimizer: Adapting Stepsizes by the Belief in Observed Gradients
", J. Zhuang et al.

@zoq zoq changed the title AdaBelief AdaBelief - Adapting Stepsizes by the Belief in Observed Gradients Oct 21, 2020
@mlpack-bot
Copy link

mlpack-bot bot commented Nov 20, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! 👍

@@ -1,3 +1,61 @@
## AdaBelief

*An optimizer for [differentiable separable functions](#differentiable-separable-functions).*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this anchor works as expected. Or is this eventually built in a way that works?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does; it's built into a larger page: http://ensmallen.org/docs.html#differentiable-separable-functions :)

Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised the reviewers didn't have a problem with this sentence:

Therefore, AdaBelief considers curvature information and performs better than Adam.

Anyway, seems like a nice technique to add regardless. :) Sorry it took so long to review this!

@@ -1,3 +1,61 @@
## AdaBelief

*An optimizer for [differentiable separable functions](#differentiable-separable-functions).*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does; it's built into a larger page: http://ensmallen.org/docs.html#differentiable-separable-functions :)

include/ensmallen_bits/ada_belief/ada_belief.hpp Outdated Show resolved Hide resolved
include/ensmallen_bits/ada_belief/ada_belief.hpp Outdated Show resolved Hide resolved
tests/ada_belief_test.cpp Outdated Show resolved Hide resolved
include/ensmallen_bits/ada_belief/ada_belief_update.hpp Outdated Show resolved Hide resolved
include/ensmallen_bits/ada_belief/ada_belief_update.hpp Outdated Show resolved Hide resolved
doc/optimizers.md Show resolved Hide resolved
@zoq
Copy link
Member Author

zoq commented Apr 7, 2021

@mlpack-jenkins test this please

Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Sorry for the slow review.

Copy link

@mlpack-bot mlpack-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second approval provided automatically after 24 hours. 👍

@zoq
Copy link
Member Author

zoq commented Jun 5, 2021

Looks good to me! Sorry for the slow review.

Let's not merge this yet, I worked locally on adapting the update step to be more closely to what the paper says.

Copy link
Member

@rcurtin rcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me here too---maybe we should merge this and the others (once you're ready) and then release a new minor version of ensmallen?

@zoq
Copy link
Member Author

zoq commented Feb 18, 2022

Everything looks good to me here too---maybe we should merge this and the others (once you're ready) and then release a new minor version of ensmallen?

Sounds good, let me resolve the merge conflict and merge it after the build comes back green.

@zoq zoq merged commit 8afcc2e into mlpack:master Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants