New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify CMake for Armadillo and its Dependencies #2247
Merged
Merged
Changes from 7 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f9047da
start simplify of arma deps
birm 29ac921
no manual openblas links
birm e1c5767
slight change to openblas get and order
birm a0a4446
restore tools directory
birm efe8e53
Rename
birm c737b0f
wrong opts renamed
birm 4a1979a
better handle no wrapper case
birm b31a761
library -> libraries
birm 6d0af7e
move dep links to findArmadillo
birm 65796c8
minor cleanup of findArma
birm 6b4148e
giving up on cleanup of config get
birm e3162bf
simplify header read
birm 6244304
special HDF5 case
birm 0725499
more closely follo hdf5 case
birm 68798dc
remove standard findblas/lapack
birm 2fd84f2
cleanup doc and quiet mode
birm File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably avoid having to change this flag by adding a case to map X_LIBRARY to X_LIBRARIES for the impacted libraries. Does this seem like a good idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific reason for using such an ancient version (0.2.14) of OpenBLAS ?
OpenBLAS has had releases with many bug fixes since then:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true, but the pipeline is currently using nuget, and the latest version there seems to be 0.2.14.1
Though there seem to be other openblas nuget projects, so we could try switching to those to get all the way to 0.2.19.3.
I think it makes more sense to consider another windows package manager such as vcpkg, as that openblas seems to be up to date. Though that's probably a different PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, we can certainly trust the Windows "world" to be a royal mess in many aspects. Instead of jumping through these silly hoops, why not just simply ship a pre-compiled copy of OpenBLAS along with mlpack?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think actually that's exactly what we're doing---we're just grabbing the version from nuget. I have no issue switching versions or anything like that... if you want to try that feel free, either in this PR or another or wherever. But yeah... the Windows distribution world is a total nightmare...