Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility with lora #6

Closed
chmxu opened this issue Jan 18, 2024 · 2 comments
Closed

compatibility with lora #6

chmxu opened this issue Jan 18, 2024 · 2 comments

Comments

@chmxu
Copy link

chmxu commented Jan 18, 2024

Hi, I wonder if you have tried using LoRA to finetune the model? It should need less gpu memory than the current full finetuning strategy.

@zwcolin
Copy link
Collaborator

zwcolin commented Jan 18, 2024

Hi Chengming,

Yes, we have attempted training with lora but encountered performance degradation with default ranks. Therefore, we did not end up having a lora finetuned version.

That said, it still might be possible to finetune with lora, although many hyperparameters (e.g., rank, types of attention weights) likely need to be carefully experimented specifically with our setup, which makes attention map itself an objective to optimize.

Best,
Zirui

@chmxu
Copy link
Author

chmxu commented Jan 18, 2024

Thank you!

@chmxu chmxu closed this as completed Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants