-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing learners on 'Integrated Learners' page #29
Comments
Wait, why are those packages not installed? They are listed in the Travis configuration and according to the log are getting installed as binary versions. |
the packages are installed, at least i guess so. |
the only chance I see is do you want to try b? |
It's like Bernd said. The packages are properly installed (at least I checked the travis log which does not show any errors in installing them), but cannot be loaded because of the DLL problem. These loading problems are caught by
What exactly do you mean by "separately"? |
I meant with b): If the tables for different learner types are in different pages in the tutorial, it might be possible to generate them im different R processes. So not all packages are loaded at once. Or do we have another chance? |
I'm not sure how many R processes we have there. My impression from the logs was always that we have one process and the number of packages accumulates over different tutorial pages. For example the log file above continues with package loading errors in
You are certainly right that it would be easier to have different R processes if the tables are on different pages in the tutorial. |
I know. But if you have separate pages, we could do this at least in principle. Or do you want to somehow manually create the page for now? Is that easier? |
At the moment it works (although it's ugly), i.e., in the current tutorial version no learners are missing in the table. The only thing I came up with yesterday is: As long term solution maybe we could
|
Ok, I agree. Like I said, my most preferred solution would be to be able to construct the learner objects without having to load their packages. This would fix everything at once. But I really dont know how hard this would be. it SHOULD be doable. |
see #580. |
We now can create the learner tables without loading packages. See mlr-org/mlr#580 ✌️ Will adapt the integrated learners page and then close. |
This is fixed now via 2b4cde6.
Just for the record:
Before the "maximal number of DLL" error there occur several other errors where packages can't be loaded although they are properly installed.
The error handling in
listLearners
catches those errors and the corresponding learners are missing in the returned list.Part of the travis log:
To fix it I replaced
listLearners
with a poor man's version without any error handling.Related commits:
3f5e33f
fedc1df
The text was updated successfully, but these errors were encountered: