-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug in TuneWrapper for param in used in predict function, issue 2472 #2479
Merged
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0967696
fix bug in TuneWrapper for param in used in predict function, issuu 2472
berndbischl c12b545
Merge branch 'master' into fix_2472
jakob-r e5d8106
fix appraoch, add test
jakob-r 875db8e
add comments to test
jakob-r 8ee08b5
Merge branch 'master' into fix_2472
jakob-r 2a0d9d0
setHyperPars
jakob-r a42c084
setHyperPars
jakob-r 68d6285
Merge branch 'master' into fix_2472
pat-s ea1bf2b
Merge branch 'master' into fix_2472
pat-s 37233c4
Merge branch 'master' into fix_2472
pat-s 1252fc0
NEWS
pat-s File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I am relatively sure that removing this line (and not putting
.learner = lrn
further down etc) will break things.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean
.learner$next.learner
? That moved to another line. But I added setHyperPars now again.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2a0d9d0 is exactly what I meant, with
.learner = lrn
I meant the list entry".learner"
👍