fix: xgboost nrounds default value (#282)

mlr-org · Jan 23, 2024 · 0e41d2c · 0e41d2c
1 parent 1caa762
commit 0e41d2c
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 1 deletion.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -49,7 +49,7 @@ Config/testthat/edition: 3
 Encoding: UTF-8
 NeedsCompilation: no
 Roxygen: list(markdown = TRUE)
-RoxygenNote: 7.2.3
+RoxygenNote: 7.2.3.9000
 Collate:
     'aaa.R'
     'LearnerClassifCVGlmnet.R'

diff --git a/NAMESPACE b/NAMESPACE
@@ -2,8 +2,10 @@
 
 S3method(default_values,LearnerClassifRanger)
 S3method(default_values,LearnerClassifSVM)
+S3method(default_values,LearnerClassifXgboost)
 S3method(default_values,LearnerRegrRanger)
 S3method(default_values,LearnerRegrSVM)
+S3method(default_values,LearnerRegrXgboost)
 export(LearnerClassifCVGlmnet)
 export(LearnerClassifGlmnet)
 export(LearnerClassifKKNN)

diff --git a/R/LearnerClassifXgboost.R b/R/LearnerClassifXgboost.R
@@ -316,5 +316,14 @@ LearnerClassifXgboost = R6Class("LearnerClassifXgboost",
   )
 )
 
+#' @export
+default_values.LearnerClassifXgboost = function(x, search_space, task, ...) { # nolint
+  special_defaults = list(
+    nrounds = 1L
+  )
+  defaults = insert_named(default_values(x$param_set), special_defaults)
+  defaults[search_space$ids()]
+}
+
 #' @include aaa.R
 learners[["classif.xgboost"]] = LearnerClassifXgboost
diff --git a/R/LearnerRegrXgboost.R b/R/LearnerRegrXgboost.R
@@ -231,5 +231,15 @@ LearnerRegrXgboost = R6Class("LearnerRegrXgboost",
   )
 )
 
+#' @export
+default_values.LearnerRegrXgboost = function(x, search_space, task, ...) { # nolint
+  special_defaults = list(
+    nrounds = 1L
+  )
+  defaults = insert_named(default_values(x$param_set), special_defaults)
+  defaults[search_space$ids()]
+}
+
+
 #' @include aaa.R
 learners[["regr.xgboost"]] = LearnerRegrXgboost