Added general unit test for label switching #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh also this PR is to address #33 |
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
======================================
Coverage 97.6% 97.6%
======================================
Files 18 18
Lines 626 626
======================================
Hits 611 611
Misses 15 15Continue to review full report at Codecov.
|
|
PR not required as mentioned in #33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added general test case to flag label switching. Tested by training each classifier against a very easy task and comparing raw output from "predict" function.
Didn't use output from
learner$predict(task)as this wouldn't have picked up #32 (i.e. in that issue,train_internalwas inverting the labels,predict_internalwas inverting the predicted labels back again, only caused issues within the model for xgboost watchlist functionality)