Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Paramtest for glmnet, add predict.gamma and newoffset arg #98

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

pat-s
Copy link
Member

@pat-s pat-s commented Apr 14, 2020

fixes #93

New parameters for glmnet:

  • predict.gamma (gamma at predict-time)
  • newoffset

Paramtest now uses predict.glmnet() instead of the non-existent predict.cv.glmnet().

@codecov-io
Copy link

codecov-io commented Apr 14, 2020

Codecov Report

Merging #98 into master will decrease coverage by 0.36%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   97.47%   97.11%   -0.37%     
==========================================
  Files          19       19              
  Lines        1031     1041      +10     
==========================================
+ Hits         1005     1011       +6     
- Misses         26       30       +4     
Impacted Files Coverage Δ
R/LearnerClassifGlmnet.R 95.60% <66.66%> (-2.08%) ⬇️
R/LearnerRegrGlmnet.R 95.00% <66.66%> (-2.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4c2acd...aeaf702. Read the comment docs.

@pat-s pat-s merged commit d35db80 into master Apr 14, 2020
@pat-s pat-s deleted the fix-93 branch April 14, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regr.glmnet does not work with offset argument
2 participants