Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add archive access methods #271

Merged
merged 14 commits into from
Feb 10, 2021
Merged

Add archive access methods #271

merged 14 commits into from
Feb 10, 2021

Conversation

be-marc
Copy link
Sponsor Member

@be-marc be-marc commented Sep 14, 2020

  • Query BenchmarkResult with ArchiveTuning methods via i-th evaluation or uhash
  • Retrieve inner tuning result of nested resampling with inner_tuning_results function.

@mllg
Copy link
Sponsor Member

mllg commented Feb 4, 2021

Two points to consider w.r.t inner_tuning_result():

  • would get_inner_tuning_result() or extract_tuning_extract() (something that starts with a verb) be a better name?
  • Should this be a S3 generic with methods for ResampleResult and BenchmarkResult?

@be-marc
Copy link
Sponsor Member Author

be-marc commented Feb 5, 2021

would get_inner_tuning_result() or extract_tuning_extract() (something that starts with a verb) be a better name?

Yes and without the word tuning since nested resampling can be also used for feature selection. extract_inner_result()? But maybe it will be easier to just implement another function in mlr3fselect.

@be-marc
Copy link
Sponsor Member Author

be-marc commented Feb 5, 2021

Should this be a S3 generic with methods for ResampleResult and BenchmarkResult?

In case of a BenchmarkResult the function would return a data.table with an extra column indicating the experiment?

@be-marc be-marc merged commit bb7eeb0 into main Feb 10, 2021
@be-marc be-marc deleted the archive_access_methods branch February 10, 2021 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants