Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #268
This is a bit of an "opinionated" PR:
$check()
is polymorphic now. This gives us$assert
and$test
for free. Note I had to split up$check
for the common stuff betweendata.frame
andlist
to avoid unnecessary repeated checks of parameter names in thedata.frame
caseDesign$new()
now checks for feasibility of its argument, because implicitly users of this were assuming that it does (principle of least surprise)Design$new()
used to "enforce" dependencies; this is optional now and does not happen by default (see point above). This may break one or two users somewhere that relying on default enforcement of deps.Design$new()
parameterremove_dupl
defaults toFALSE
now because that is obviously the right choice for a default here.If there are small problems with this please fix or delegate to a
hiwicontributor.