Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PureRenderMixin #10

Open
mlsteele opened this issue Jul 29, 2014 · 1 comment
Open

Use PureRenderMixin #10

mlsteele opened this issue Jul 29, 2014 · 1 comment
Assignees
Labels

Comments

@mlsteele
Copy link
Owner

Almost all of the components in this app are pure.
We should use PureRenderMixin

Also, it would be interesting to benchmark various UI changes to see whether this makes a difference. It still feels a bit slow on mobile.

Maybe doing "onChange -> rerender app" is slow.
Try using setprops on the outer component (forcing the update against PureRenderMixin) instead.
"Calling React.renderComponent() again on the same node is the preferred way to update a root-level component."

http://facebook.github.io/react/docs/component-api.html#forceupdate

@mlsteele mlsteele self-assigned this Jul 31, 2014
@mlsteele
Copy link
Owner Author

Render is async. How should I measure how long it takes?

@mlsteele mlsteele added the bug label Jul 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant