-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crash and bad frames generated #101
Comments
I only took a quick look into this, and I am not very motivated at the moment to dig into it deeper. Most people that want to use composite as a filter use the watermark filter, and filter_transition is actually seldom used. However, I see you are also doing geometry animation, and composite/watermark really sucks for that because it does not support sub-pixel interpolation, and it operates in YUV 4:2:2, which means it only has 2 pixel precision - not even 1! Therefore, I recommend using the affine transition/filter, which does interpolation. |
But you are going to fix it, right? On one day? |
Someone will probably look at it some day. It is difficult to determine the priority because we don't know anything about your project or how many people it affects. |
Problem reproduced by segfault.sh in at:
it happens because of size of image returned from:
differ:
then image allocated at video_avframe as result it cause memcpy to access memory outside of received image. May be scaler not inserted? |
Problem reproduced by artifacts.sh has similar nature. Frame 0 (broken/corrupted)
Frame 1 (broken/corrupted)
Frame 2 (normal)
It seems no normalizing filters attached/executed. as result avformat consumer receives frames that is not in profile sizes... |
Hi,
If you run segfault.sh, you will see a crash in customer because the resolution of the image is not what is expect, an image with a bad resolution is copied.
It also causes bad frames in video, broken frames, noisy pictures..
Try artifacts.sh
My debugging showed me what for first frame , the producer returns bad resolution, not for the rest.
artifacts.zip
The text was updated successfully, but these errors were encountered: