-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MacOS: Create symlink to the qml folder after building #1415
MacOS: Create symlink to the qml folder after building #1415
Conversation
Automatically create the symlink post build if it doesn't exist, since we only copy the qml folder to the Resource path during install.
I noticed that the Linux build uses |
file(CREATE_LINK...) causes CMake config to fail with the following: Shotcut.app/Contents/Resources/qml': This happens with a fresh build. As of now I'm not sure why this is happening, but will try building for Linux and compare. |
|
Maybe you need the |
src/CMakeLists.txt
Outdated
@@ -295,6 +295,10 @@ if(APPLE) | |||
target_sources(shotcut PRIVATE ${APP_ICON}) | |||
set_source_files_properties(${APP_ICON} PROPERTIES MACOSX_PACKAGE_LOCATION "Resources") | |||
|
|||
#Create a symlink to the qml folder after building | |||
file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/Shotcut.app/Contents/Resources/qml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MAKE_DIRECTORY should not have "/qml" at the end as that is the symlink in the next line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, my bad. Will fix it.
Automatically create the symlink post build if it doesn't exist, since we only copy the qml folder to the Resource path during install.