Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS: Create symlink to the qml folder after building #1415

Conversation

zadockmaloba
Copy link
Contributor

Automatically create the symlink post build if it doesn't exist, since we only copy the qml folder to the Resource path during install.

Automatically create the symlink post build if it doesn't exist, since we only copy the qml folder to the Resource path during install.
@ddennedy
Copy link
Member

ddennedy commented Mar 21, 2023

I noticed that the Linux build uses
file(CREATE_LINK ${CMAKE_SOURCE_DIR}/src/qml ${CMAKE_BINARY_DIR}/share/shotcut/qml SYMBOLIC)

@zadockmaloba
Copy link
Contributor Author

I noticed that the Linux build uses
file(CREATE_LINK ${CMAKE_SOURCE_DIR}/src/qml ${CMAKE_BINARY_DIR}/share/shotcut/qml SYMBOLIC)

file(CREATE_LINK...) causes CMake config to fail with the following:

Shotcut.app/Contents/Resources/qml':
No such file or directory

This happens with a fresh build. As of now I'm not sure why this is happening, but will try building for Linux and compare.

@zadockmaloba
Copy link
Contributor Author

I noticed that the Linux build uses
file(CREATE_LINK ${CMAKE_SOURCE_DIR}/src/qml ${CMAKE_BINARY_DIR}/share/shotcut/qml SYMBOLIC)

file(CREATE_LINK...) causes CMake config to fail with the following:

Shotcut.app/Contents/Resources/qml': No such file or directory

This happens with a fresh build. As of now I'm not sure why this is happening, but will try building for Linux and compare.

file(CREATE_LINK ${CMAKE_SOURCE_DIR}/src/qml ${CMAKE_CURRENT_BINARY_DIR}/Shotcut.app/Contents/Resources/qml SYMBOLIC)

@ddennedy
Copy link
Member

Maybe you need the file(MAKE_DIRECTORY... that is on the previous line.

@@ -295,6 +295,10 @@ if(APPLE)
target_sources(shotcut PRIVATE ${APP_ICON})
set_source_files_properties(${APP_ICON} PROPERTIES MACOSX_PACKAGE_LOCATION "Resources")

#Create a symlink to the qml folder after building
file(MAKE_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/Shotcut.app/Contents/Resources/qml)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAKE_DIRECTORY should not have "/qml" at the end as that is the symlink in the next line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, my bad. Will fix it.

@ddennedy ddennedy merged commit aa5b37a into mltframework:master Mar 22, 2023
@ddennedy ddennedy added this to the next release milestone Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants