Compatibility with multi-dimensional arrays; closes #19 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlubin
reviewed
May 30, 2017
src/NaNMath.jl
Outdated
| @@ -44,7 +44,7 @@ using NaNMath as nm | |||
| nm.sum([1., 2., NaN]) # result: 3.0 | |||
| ``` | |||
| """ | |||
| function sum{T<:AbstractFloat}(x::Vector{T}) | |||
| function sum{T<:AbstractFloat}(x::AbstractArray{T}) | |||
| if size(x)[1] == 0 | |||
There was a problem hiding this comment.
This check probably needs to change
was removed by mistake
|
🎉 Thanks a lot for working so promptly on this |
|
When you're happy with what's here, let me know and I can tag a new release. |
|
I'm quite happy now - it'd be nice to have the two-arg versions of the functions for multi-dim arrays too, but that is quite a lot more involved, of course. See what you think - after merging this (or now, if you'd prefer not to merge that PR) I'd be happy for a release. This seems to have solved my problems downstream in Plots :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.