Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Specs2 1.9 #4

Closed
wants to merge 2 commits into from
Closed

Conversation

taylorleese
Copy link

I ran into two different classpath issues that took me a while to track down until I realized they were related to trying to use specs2 1.9 while the plugin was still using specs2 1.6.1 and mockito 1.8.5.

@mmakowski
Copy link
Owner

Thanks for this. I'll have a look at integrating this over the weekend. The merge is trivial, but I'll have to do a bit of work to publish the release to Maven Central.

I might also fix it properly, i.e. make the plugin use whichever version of specs2 is specified in project's pom, if I find time.

@ghost ghost assigned mmakowski Apr 12, 2012
@taylorleese
Copy link
Author

That would be even better.

@mmakowski
Copy link
Owner

I have now updated the plugin to not pull in its own version of specs2/mockito/hamcrest. I still have issues releasing it (probably a fallout of migration from scala-tools to Sonatype OSS), but will have 0.3.0 released as soon as I manage to resolve them.

Thanks for prompting me to finally implement this properly!

@mmakowski mmakowski closed this Apr 15, 2012
@taylorleese
Copy link
Author

Great, I'll give it a try once it's in the central maven repo. I've published a few artifacts there so let me know if you have any troubles.

@taylorleese
Copy link
Author

Has this been published to maven central yet?

@mmakowski
Copy link
Owner

No, apologies -- haven't had the time to follow up with Sonatype guys. I'll give it a go today.

@mmakowski
Copy link
Owner

Issue raised with Sonatype: https://issues.sonatype.org/browse/MVNCENTRAL-198

@mmakowski
Copy link
Owner

0.3.0 is now in maven central. Please let me know in case of any problems with it.

@taylorleese
Copy link
Author

Thanks. It worked fine except for one nuance which is that I had to add specs2 as a dependency in my parent pom rather than each individual module's POM since I had the plugin defined in the parent pom. Not a big deal, but something you should be aware of. This actually fixed another classpath issue I was having with mockito as well.

@mmakowski
Copy link
Owner

Thanks for the feedback. I opened Issue #5 to track it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants