Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERR_NOMOTD is unhandled #7

Closed
edef1c opened this issue Mar 9, 2013 · 1 comment · Fixed by #8
Closed

ERR_NOMOTD is unhandled #7

edef1c opened this issue Mar 9, 2013 · 1 comment · Fixed by #8
Labels

Comments

@edef1c
Copy link
Collaborator

edef1c commented Mar 9, 2013

No 'motd' event is emitted on an ERR_NOMOTD.
This also causes initialisation to hang with a missing MOTD.
Possible resolutions:

  • have a separate event for ERR_NOMOTD
    • upside: entirely unambiguous
    • downside: weird edge case (motd event is expected except in this weird edge case)
  • .emit('motd', null)
    • upside: meaning is clear
    • downside: sort of a weird edge case (strings are expected except in this edge case)
  • .emit('motd', '')
    • upside: everyone's code is ready to handle it (they already handle strings)
    • downside: meaning is less clear / conflicts with empty MOTD
@edef1c
Copy link
Collaborator Author

edef1c commented Mar 9, 2013

I pullreq'd both approaches. Pick one [=

edef1c added a commit that referenced this issue Mar 10, 2013
@edef1c edef1c closed this as completed in bd5c657 Apr 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant