Fix HTTPException to not be thrown on every Facebook error #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmangino
added a commit
that referenced
this pull request
Nov 21, 2011
Fix HTTPException to not be thrown on every Facebook error
derwiki
pushed a commit
to causes/mogli
that referenced
this pull request
Apr 16, 2012
Conflicts: mogli.gemspec origin/master was the HEAD of master before this merge happened. * 703f1dd (HEAD, master) Merge remote-tracking branch 'upstream/master' |\ | * cf14773 (upstream/master) Merge pull request mmangino#108 from jonasfa/master | |\ | | * b241486 Adding the 'installed' field to User | |/ | * 9c11855 Merge branch 'master' of github.com:mmangino/mogli | |\ | | * 86dde11 Merge pull request mmangino#106 from shwing/master | | |\ | | | * 4101888 daily_active_users to application, likes to photos | | |/ | | * cd9fc21 Merge pull request mmangino#104 from ckbhodge/patch-1 | | |\ | | | * b8aa965 added property for 'interested_in' which should be valid: https://developers.facebook.com/docs/reference/api/user/ | | |/ | | * 79bb3fc Merge pull request mmangino#101 from adahmash/master | | |\ | | | * 90d2a14 Added Events assocation to mogli user | | | * 9b812aa Upgraded hashtie version for dependency | | |/ | | * 46d0c32 Merge pull request mmangino#98 from lecky/master | | |\ | | | * 14cd054 add subscription model | | |/ | * | bccb36b Gemspec change | * | 3a0c5aa Just deleted the get_and_map method which causes an OAuthException when using create_and_authenticate_as_application for an AppRequest. Travis needs to implement it differently for his TestUser class. | |/ | * fa7b72d Merge pull request mmangino#96 from intinig/master | |\ | | * 04f74c7 adding application | | * 1a428a6 user likes | | * 39646ed Revert "Revert "adding missing fields to comments"" | | * a776856 Revert "adding missing fields to comments" | | * 12cf200 adding missing fields to comments | | * f7931c4 adding comments and likes to statuses | |/ | * d55c3b5 Merge pull request mmangino#93 from herval/master | |\ | | * 7da769c friends likes perm | | * 4032aa0 publish_actions | * | 1ab9b78 Merge pull request mmangino#77 from tadruj/patch-1 | |\ \ | | * | e29fd7a removed .parsed_response | * | | 4795a4e Merge pull request mmangino#92 from s1kx/master | |\ \ \ | | * | | 833fbd3 Check Facebook error first before throwing a HTTPException | |/ / / | * | | 8936d63 Merge branch 'master' of github.com:mmangino/mogli | |\ \ \ | | * \ \ 4391368 Merge pull request mmangino#89 from jfeng/raise_oauth_error | | |\ \ \ | | | |_|/ | | |/| | | | | * | 70e9114 enable SessionInvalidatedDueToPasswordChange raised | | |/ / | * | | 2989e21 Clean up profile image code | * | | 5f8bc41 Merge branch 'master' of github.com:mmangino/mogli | |\ \ \ | | |/ / | | * | a42bcec Merge pull request mmangino#86 from stupied4ever/patch-1 | | |\ \ | | | * | 0a55d20 Update lib/mogli/profile.rb | | |/ / | * | | c71b52d Merge branch 'master' of github.com:mmangino/mogli | |\ \ \ | | |/ / | | * | 91c726c Merge pull request mmangino#85 from taweili/master | | |\ \ | | | * | 48e80b6 use HTTMultiParty to support file upload | | |/ / | * | | c7ac4e1 Add info to readme for creating photos | * | | b58af15 merge | * | | 1db5371 Bump version * | | | 69f6682 (origin/master, origin/HEAD) Store total counts on * FetchingArray when fb returns a "count" attribute * | | | f7c5a5c Merge remote-tracking branch 'spidaman/master' |\ \ \ \ | * | | | 6f4f08c (origin/sandbox/richard/mogli) added support for querying permissions and support for understanding batch query responses | * | | | 6c922f2 bumped version to 0.3.5 | * | | | 5d3247f added friendlists support | * | | | bc2c750 added the rsvp_status attribute to events | * | | | b2f6d85 added Place model | | |/ / | |/| |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Facebook occurs on Graph API calls, the server replies with a 403 HTTP error code. Thus mogli would always throw a HTTPException without any further information on it (thrown by raise_error_if_necessary).
By first checking the response body for an error message and type, we make sure that we get proper exceptions in all cases.