Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running multiple devices #54

Merged
merged 9 commits into from
Mar 1, 2020
Merged

Running multiple devices #54

merged 9 commits into from
Mar 1, 2020

Conversation

mmarkelov
Copy link
Member

@mxschmitt
Copy link
Collaborator

cool!

@mmarkelov
Copy link
Member Author

I suppose that we should able run tests for devices without defined browsers in config.
Cases:

  • We defined browsers and devices:
module.exports = {
     browsers: [ 'chromium', 'firefox'],
     devices: ['iPhone 6', 'Pixel 2']
}

For this case we need run 4 tests:

  1. chromium and iPhone 6
  2. chromium and Pixel 2
  3. firefox and iPhone 6
  4. firefox and Pixel 2
  • We defined devices:
module.exports = {
     devices: ['iPhone 6', 'Pixel 2']
}

If we are using standalone version, for example playwright-webkit, we should run 2 tests:

  1. webkit and iPhone 6
  2. webkit and Pixel 2

But I'm not sure what to do for playwright. Should it run for default chromium browser? Also browser can be defined with env variable

@mxschmitt
Copy link
Collaborator

I suppose that we should able run tests for devices without defined browsers in config.
Cases:

  • We defined browsers and devices:
module.exports = {
     browsers: [ 'chromium', 'firefox'],
     devices: ['iPhone 6', 'Pixel 2']
}

For this case we need run 4 tests:

  1. chromium and iPhone 6
  2. chromium and Pixel 2
  3. firefox and iPhone 6
  4. firefox and Pixel 2
  • We defined devices:
module.exports = {
     devices: ['iPhone 6', 'Pixel 2']
}

If we are using standalone version, for example playwright-webkit, we should run 2 tests:

  1. webkit and iPhone 6
  2. webkit and Pixel 2

But I'm not sure what to do for playwright. Should it run for default chromium browser? Also browser can be defined with env variable

If they are using playwright I would only run it on chromium as you said. So chromium is the default. If they specify the browsers setting manually, then it will be overwritten.

@mmarkelov mmarkelov marked this pull request as ready for review March 1, 2020 11:13
@mmarkelov
Copy link
Member Author

@mxschmitt I think I'm done here

Copy link
Collaborator

@mxschmitt mxschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job!

@mmarkelov mmarkelov merged commit cc768ef into master Mar 1, 2020
@mmarkelov mmarkelov deleted the Running-multiple-devices branch March 1, 2020 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants