Skip to content

Commit

Permalink
Correct singularName for UploadTokenRequests
Browse files Browse the repository at this point in the history
(At least) by convention names and singularNames are all lower case. If
they're not, it might confuse client libraries that don't lowercase
everything proactively. Example:
openshift/openshift-restclient-python#250
  • Loading branch information
mmazur committed Dec 18, 2018
1 parent 9558460 commit 9e70b47
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pkg/apiserver/apiserver.go
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ func (app *cdiAPIApp) composeUploadTokenAPI() {
list.GroupVersion = uploadTokenGroup + "/" + uploadTokenVersion
list.APIResources = append(list.APIResources, metav1.APIResource{
Name: "uploadtokenrequests",
SingularName: "UploadtokenRequest",
SingularName: "uploadtokenrequest",
Namespaced: true,
Group: uploadTokenGroup,
Version: uploadTokenVersion,
Expand Down
2 changes: 1 addition & 1 deletion pkg/apiserver/apiserver_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ func TestGetAPIResouceList(t *testing.T) {
APIResources: []metav1.APIResource{
{
Name: "uploadtokenrequests",
SingularName: "UploadtokenRequest",
SingularName: "uploadtokenrequest",
Namespaced: true,
Group: "upload.cdi.kubevirt.io",
Version: "v1alpha1",
Expand Down

0 comments on commit 9e70b47

Please sign in to comment.