New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make feature_row work well with all layouts #1484

Closed
lsolesen opened this Issue Jan 17, 2018 · 7 comments

Comments

Projects
None yet
2 participants
@lsolesen
Contributor

lsolesen commented Jan 17, 2018

  • This is a question about using the theme.
  • This is a feature request.
  • I believe this to be a bug with the theme.
    • I have updated all gems with bundle update.
    • I have tested locally with bundle exec jekyll build.

Environment informations

  • Minimal Mistakes version:
  • Jekyll version:
  • GitHub Pages hosted: yes/no
  • Operating system:

Expected behavior

The feature_row helper is really nice - and really close to look nice with other layouts than ´splash´. I would be really cool if small tweaks would be made to make feature_row usable on all layouts.

Steps to reproduce the behavior

Here you see how close it is to look nice on e.g. the ´archive´ layout.

skaermbillede 2018-01-17 kl 17 36 46

It seeks that these tweaks needs to be made for other layouts:

  • fill container in width
  • make sure that the headline is scaled down a bit and less top margin

That would make them usable in other layouts also, which will make the feature_row even more useful.

@mmistakes

This comment has been minimized.

Owner

mmistakes commented Jan 17, 2018

Do you have a repo with this example? I'd like to drop it in to a test page and see how hard it would be to add some CSS to make feature rows more portable.

@lsolesen

This comment has been minimized.

Contributor

lsolesen commented Jan 17, 2018

On this branch - https://github.com/vih/historie/tree/yearbook

When build the screenshot is from /yearbooks/2017/ and there is an example on "left" and "center" on /yearbooks/

@lsolesen

This comment has been minimized.

Contributor

lsolesen commented Jan 17, 2018

Just an extra question regarding feature_row. On :hover on either the picture or the headline, the headlines get underlined, and that makes me want to click them (as they act like a link), but that is not possible, which seems a little counterintuitive. Does this qualify for another issue - or is it on purpose?

@mmistakes

This comment has been minimized.

Owner

mmistakes commented Jan 17, 2018

Thanks.

And agree on the hover state of feature rows. That's something I recently removed but haven't pushed up yet.

@mmistakes

This comment has been minimized.

Owner

mmistakes commented Jan 17, 2018

Was a pretty easy fix so I pushed a couple of updates. Here's an example of an archive page with feature rows placed after (might have to flush your browser's cache to get the latest CSS).

In your example where you're using a grid wrapper to expand the main content's width, you need to place the feature row includes inside of that <div>. That will allow the feature rows to fill the entire area without the space on the right.

{% assign site_posts = site.posts | where: "tags", page.title | sort: "date" %}

<div class="grid__wrapper">
  {% include feature_row id="intro" type="center" %}

  {% for post in site_posts %}
    {% include archive-single.html %}
  {% endfor %}

  <h2>Har du også læst?</h2>
  {% include feature_row type="left" %}
  {% include feature_row id="feature_row_2" type="right" %}
  {% include feature_row %}
</div>
@mmistakes

This comment has been minimized.

Owner

mmistakes commented Jan 17, 2018

Example with updated CSS:

image

@lsolesen

This comment has been minimized.

Contributor

lsolesen commented Jan 17, 2018

Awesome. Thanks for your work on this theme. The theme is reason I like Jekyll so much :)

@mmistakes mmistakes closed this Jan 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment