New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public Staticman server is hitting GitHub API limits #1842

Closed
maxime-michel opened this Issue Sep 19, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@maxime-michel
Contributor

maxime-michel commented Sep 19, 2018

I would like to raise awareness about recent issues me and others have experienced with Staticman.

The first is that it is becoming almost impossible to get an 'OK' back when adding the bot as a repository collaborator: eduardoboucas/staticman#227.

The second is that some comments might possibly get lost due to the public instance (api.staticman.net) hitting GitHub API limits: eduardoboucas/staticman#222

The solution to those problems is to allow people to define a custom URL for their own deployment of Staticman. But I also believe some awareness about the potential issues should be present in the documentation.

Another idea could be that the theme transparently uses its own deployment of Staticman. It would greatly reduce the simplicity if we had one instance to host N users, rather than N users paying for and setting up one instance individually. But somebody's got to handle it at the end of the day, and that would have to be well organized.

Any thoughts?

PS: this is an excellent theme and a great framework! I wish I had joined the party sooner.

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Sep 19, 2018

Owner

Thanks for bringing it up. Not sure on the best path forward.
I guess anyone who relies on the public instance probably needs a backup plan. Kind of comes with the territory when using "free" stuff.

Owner

mmistakes commented Sep 19, 2018

Thanks for bringing it up. Not sure on the best path forward.
I guess anyone who relies on the public instance probably needs a backup plan. Kind of comes with the territory when using "free" stuff.

@maxime-michel

This comment has been minimized.

Show comment
Hide comment
@maxime-michel

maxime-michel Sep 19, 2018

Contributor

Would you be OK with a PR that opens the endpoint URL to possible configuration?

Contributor

maxime-michel commented Sep 19, 2018

Would you be OK with a PR that opens the endpoint URL to possible configuration?

@mmistakes

This comment has been minimized.

Show comment
Hide comment
@mmistakes

mmistakes Sep 19, 2018

Owner

Yeah I'd be cool with that. Could probably do something like {{ site.staticman.endpoint | default: 'https://api.staticman.net/v2/entry/' }} to fallback to the public instance if one isn't specified in _config.yml.

Owner

mmistakes commented Sep 19, 2018

Yeah I'd be cool with that. Could probably do something like {{ site.staticman.endpoint | default: 'https://api.staticman.net/v2/entry/' }} to fallback to the public instance if one isn't specified in _config.yml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment