-
Notifications
You must be signed in to change notification settings - Fork 19
Please don't make filters.txt bigger #1
Comments
I am glad to hear that the filters are working well for you! I would, however, suggest that the use of proper filters such as EasyList and EasyPrivacy would be more suitable for AdGuard Pro as it can interpret / support a much wider variety of filter options. The filters that have been created for this repo have been 'dumbed down' to try to apply basic blocking where the advanced traffic analysis is not available. I do not plan to add any additional host sources at present, but will consider the possibility of separating them out if necessary in the future. If the AdGuard Home code is tweaked so that more 'options' are processed as wildcard blocks, there will be no reason for this repo to exist. It's really a temporary measure until there's a solution in-place :-) |
Thanks for your answer! Regarding EasyList and EasyPrivacy: I know that. The thing is that AdGuard Pro for iOS consists of 2 parts:
That's why I sincerely hope that your "temporary measure" will exist for a long time ;-) |
I don't use your filters in AdGuardHome as I went back to Pi-Hole which I like better (and which I'm using with your other scripts).
However, I'm successfully using your
filters.txt
andregex.txt
in AdGuard Pro on my iPhone and iPad. I've added them as subscriptions to the "Privacy Settings" which allows for a system-wide blocking on those devices via a local VPN. I seriously think that your lists are simply the best available!There is just one possible problem: When I added several hosts files in the past I was faced with the problem mentioned on above site:
Fortunately, this does not happen with your lists: They block all sub-domains of those trackers/adservers/etc. but are not that big to cause a tunnel crash.
So my plea is: Don't make filters.txt bigger as it is now as it would probably no longer work in AdGuard Pro.
If you really plan to add new hosts files I suggest to offer them as separate filterlists for AdGuardHome (where a tunnel crash does not occur).
Thanks for considering this and thanks for your great work!
The text was updated successfully, but these errors were encountered: