Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero day images have spiky noise #14

Closed
mmp opened this issue Aug 18, 2020 · 2 comments
Closed

Zero day images have spiky noise #14

mmp opened this issue Aug 18, 2020 · 2 comments

Comments

@mmp
Copy link
Owner

mmp commented Aug 18, 2020

There's a lot of spiky noise in the zero day scenes that looks like an MIS issue:

Screenshot from 2020-08-18 15-54-31

Things learned so far:

  • It even happens with --force-diffuse, so it's presumably not an issue with concentrated indirect light
  • It happens with both the path and volpath integrators (and both the CPU and GPU volpath integrators), so it's presumably not an issue with MIS computations in the integrators
  • It is being added when a BSDF-sampled ray hits a light source (hence, the assumption that something is wrong with MIS weights)
  • It happens with both solid angle sampling and uniform area sampling of the triangular light sources, so is not related to e.g. solid angle sampling blowing up for very small triangles.
  • It happens with both the BVH and the "power" light sampler, so is presumably not related to the BVH light sampler e.g. incorrectly returning zero probability for sampling a light.
  • It doesn't happen with "maxdepth" 1.

...and that's as much as I've figured out so far.

@mmp
Copy link
Owner Author

mmp commented Aug 18, 2020

And also: it still happens if bump mapping and per-vertex normals are disabled, so is presumably not a shading normals issue..

mmp added a commit that referenced this issue Sep 24, 2020
(And eliminate the SampledPDFIsProportional() method from the BxDF
interface.)

This fixes a previously-unknown(*) bug that was causing noise in some
scenes. The issue is that the LayeredBxDF actually doesn't always return a
proportional PDF: if the path scatters at the interface and doesn't enter
the layers, the BSDFSample is a regular one. The PDF is only proportional
if the path starts bouncing around in there...

(*) This could be the issue noted in #14--not yet confirmed...
@mmp
Copy link
Owner Author

mmp commented Oct 26, 2021

Many things have been fixed since this and the noise now seems reasonable to the point that it now seems plausibly expected noise from tricky indirect lighting.

@mmp mmp closed this as completed Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant