Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated warning in PHP 8.2.8 #67

Closed
ggieling opened this issue Jul 18, 2023 · 4 comments
Closed

Deprecated warning in PHP 8.2.8 #67

ggieling opened this issue Jul 18, 2023 · 4 comments

Comments

@ggieling
Copy link

I get the below warning when using krumo 0.7.0 in a php 8.2.8 environment

Deprecated: Use of "static" in callables is deprecated in ..../class.krumo.php on line 1522
Deprecated: Use of "static" in callables is deprecated in ..../class.krumo.php on line 1523

corresponding lines in class.krumo.php are:

1522            $_    = preg_replace_callback( "/^([ \t]+)/", "static::convert_whitespace", $_);
1523            $_    = preg_replace_callback( "/([ \t]+)$/", "static::convert_whitespace", $_);

I don't know when this will change from deprecated to forbidden, but it is probably relevant to tackle this before the change.

@scottchiefbaker
Copy link
Collaborator

I just landed 0052ffd which should fix this issue. Thanks for the heads up. I don't have PHP 8.2 in production yet, so I haven't tested much with it.

Can you confirm this fixes the issue for you?

@ggieling
Copy link
Author

It works, the warning is gone

I have not (yet) seen new warnings or errors popping up by this change

@driehle
Copy link
Contributor

driehle commented Aug 14, 2024

@scottchiefbaker While 0052ffd indeed fixes this issue, unfortunately, no release has yet been made with that change.

Would it be possible to make a new release? Remember to update the Kruma::VERSION constant before... ;-)

@scottchiefbaker
Copy link
Collaborator

I just released v0.7.2 with this fix. Give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants