Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_check_fresh_repo is failing because of length of generated tmp folder #7

Closed
benediktarnold opened this issue Dec 15, 2014 · 2 comments

Comments

@benediktarnold
Copy link
Contributor

Hi,

I have a failing test because the path of the generated tmp folder is longer than you expect it to be. I have less whitespace characters between the path and : Changes

I would suggest to make the String comparison less strict. What about an expression to check if the output is partially as expected? Ignoring two many whitespace characters?

Cheers,
Ben

======================================================================
FAIL: tests.clustergit_test.TestClustergit.test_check_fresh_repo
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/Users/ben/dev/projects/oss/clustergit/tests/tests/clustergit_test.py", line 55, in test_check_fresh_repo
    same("stdout should be alright", expected_out, actual_out)
  File "/Users/ben/dev/projects/oss/clustergit/tests/tests/tools.py", line 4, in same
    eq_(actual, expected, '%s. We expected [%s] but got [%s]' % (message, expected, actual))
AssertionError: stdout should be alright. We expected [Starting git status...
Scanning sub directories of /var/folders/qz/pkd6t5v52d9b2w01nc2f587h0000gp/T/tmpuqsbOv
/var/folders/qz/pkd6t5v52d9b2w01nc2f587h0000gp/T/tmpuqsbOv/mygit                    : Changes
Done
] but got [Starting git status...
Scanning sub directories of /var/folders/qz/pkd6t5v52d9b2w01nc2f587h0000gp/T/tmpuqsbOv
/var/folders/qz/pkd6t5v52d9b2w01nc2f587h0000gp/T/tmpuqsbOv/mygit: Changes
Done
]
@mnagel
Copy link
Owner

mnagel commented Dec 16, 2014

please check if this is fixed with 668c981

@benediktarnold
Copy link
Contributor Author

That's it. Thanks!

@mnagel mnagel closed this as completed Dec 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants