Skip to content

Commit

Permalink
Remove special-casing for NIRS bids-validator
Browse files Browse the repository at this point in the history
The stable bids-validator now officially supports NIRS,
so there's no need anymore for using Rob's personal branch.
  • Loading branch information
hoechenberger committed Sep 1, 2022
1 parent 02cd13f commit d2a5375
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 30 deletions.
28 changes: 2 additions & 26 deletions .github/workflows/unit_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -124,22 +124,6 @@ jobs:
mne-version: mne-main
bids-validator-version: validator-main

# Tests with the NIRS branch of bids-validator
- os: ubuntu-latest
python-version: "3.10"
mne-version: mne-main
bids-validator-version: validator-NIRS

- os: macos-latest
python-version: "3.10"
mne-version: mne-main
bids-validator-version: validator-NIRS

- os: windows-latest
python-version: "3.10"
mne-version: mne-main
bids-validator-version: validator-NIRS

env:
TZ: Europe/Berlin
FORCE_COLOR: true
Expand Down Expand Up @@ -197,16 +181,8 @@ jobs:
popd
echo "BIDS_VALIDATOR_BRANCH=main" >> $GITHUB_ENV
- name: Download BIDS validator (NIRS)
if: "matrix.bids-validator-version == 'validator-NIRS'"
run: |
pushd ..
git clone --depth 1 --branch nirs https://github.com/rob-luke/bids-validator.git
popd
echo "BIDS_VALIDATOR_BRANCH=NIRS" >> $GITHUB_ENV
- name: Install BIDS validator (main or NIRS)
if: ${{ (matrix.bids-validator-version == 'validator-main') || (matrix.bids-validator-version == 'validator-NIRS') }}
- name: Install BIDS validator (main)
if: "matrix.bids-validator-version == 'validator-main'"
run: |
pushd ..
cd bids-validator
Expand Down
4 changes: 0 additions & 4 deletions mne_bids/tests/test_write.py
Original file line number Diff line number Diff line change
Expand Up @@ -1719,10 +1719,6 @@ def test_eegieeg(dir_name, fname, reader, _bids_validate, tmp_path):
_bids_validate(output_path)


@pytest.mark.skipif(
os.environ.get('BIDS_VALIDATOR_BRANCH') != 'NIRS',
reason="requires Rob's NIRS branch of bids-validator"
)
def test_snirf(_bids_validate, tmp_path):
"""Test write_raw_bids conversion for SNIRF data."""
raw_fname = op.join(testing.data_path(), 'SNIRF', 'MNE-NIRS', '20220217',
Expand Down

0 comments on commit d2a5375

Please sign in to comment.