Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use mne's apply_function #34

Open
pmyers16 opened this issue Mar 31, 2021 · 0 comments
Open

Refactor to use mne's apply_function #34

pmyers16 opened this issue Mar 31, 2021 · 0 comments

Comments

@pmyers16
Copy link
Collaborator

Describe the problem

Standardizing the detector functions is very important, so we need a good way of ensuring that a standard is held. This is a down the line nice-to-have.

Describe your solution

We could refactor each of our detectors to work with mne's apply_function
https://mne.tools/stable/generated/mne.io.Raw.html#mne.io.Raw.apply_function
which should do some of the channel processing for us.

Describe possible alternatives

The current method works since we are at least constrained within the sklearn standard. This refactor would be in addition to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant