Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code credit dedup #12818

Closed
drammock opened this issue Aug 27, 2024 · 2 comments · Fixed by #12820
Closed

code credit dedup #12818

drammock opened this issue Aug 27, 2024 · 2 comments · Fixed by #12820

Comments

@drammock
Copy link
Member

Some possible deduplications:

  • Jean-Remi KING and Jean-Remi King are separate entries
  • Valerii and Valerii Chirkov
  • PAB and Pierre-Antoine Bannier
  • Jordan Drew and Drew, J.
  • Deleted user still shows up (even though it's trying to be excluded in update_credit_rst.py)

Something I think we discussed before, but I can't recall what was decided:

  • there are some folks who I'm pretty sure are in our .mailmap but their usernames aren't getting parsed out here (TzionaN, Sena, and Martin are a few examples I noticed; probably there are more). Did we decide not to use .mailmap for some reason? Or is it a bug that these users aren't getting the preferred name displayed?
@larsoner
Copy link
Member

larsoner commented Aug 28, 2024

Regarding names when things were ambiguous I think I tried to side with names.inc. There are three potential sources of truth: that, GitHub profile, and .mailmap. I figure mailmap is most remote from the users (maintained by us) so we should probably try to make it match the other two (esp. names.inc since users typically had to make a conscious choice at time of contribution for that) but not 100% sure.

@larsoner
Copy link
Member

I should be able to look into this tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants