Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compute_proj_ecg throws a warning #166

Closed
larsoner opened this issue Oct 29, 2012 · 3 comments
Closed

compute_proj_ecg throws a warning #166

larsoner opened this issue Oct 29, 2012 · 3 comments

Comments

@larsoner
Copy link
Member

I get a warning when using the default parameters for compute_proj_ecg:

/home/larsoner/.local/lib/python2.7/site-packages/mne-0.4.git-py2.7.egg/mne/filter.py:234: UserWarning: Attenuation at stop frequency 4.5Hz is only 15.1dB. Increase filter_length for higher attenuation.

I assume this has to do with the 5 Hz high-pass frequency requiring a long FIR filter.

Would it make sense to set the filter_length argument to something larger by default for compute_proj_ecg?

@larsoner
Copy link
Member Author

And changing filter_length to 4096 from the default of 2048 makes it so no warning is thrown.

Any objections to changing it to 4096?

@larsoner
Copy link
Member Author

Changing the default to 4096, that is.

@agramfort
Copy link
Member

Yes go ahead !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants