Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epochs dict features don't work with save to fiff #238

Closed
mluessi opened this issue Dec 7, 2012 · 8 comments
Closed

Epochs dict features don't work with save to fiff #238

mluessi opened this issue Dec 7, 2012 · 8 comments

Comments

@mluessi
Copy link
Contributor

mluessi commented Dec 7, 2012

The dict features introduced in #229 are not compatible with saving to fiff in the sense that if you have an Epochs object with named events, save it, and load it again, the event names will be lost.

@dengemann
Copy link
Member

... mhm, that's true. i did it so that the events get converted to keys. so restoring the names shouldn't be that difficult for the user. but to improve this, is there some field / corner in a fiff we could abuse for saving the mappings?

On 07.12.2012, at 18:40, Martin Luessi notifications@github.com wrote:

The dict features introduced in #229 are not compatible with saving to fiff in the sense that if you have an Epochs object with named events, save it, and load it again, the event names will be lost.


Reply to this email directly or view it on GitHub.

@agramfort
Copy link
Member

you can use a comment field as for Evoked. And serialize the dict in a string eg.

"visual:3;auditory:1"

wdyt?

@agramfort
Copy link
Member

not in comment but event_id tag or something...

@dengemann
Copy link
Member

excellent! tha mapping could then be easily restored!

On 07.12.2012, at 19:02, Alexandre Gramfort notifications@github.com wrote:

you can use a comment field as for Evoked. And serialize the dict in a string eg.

"visual:3;auditory:1"

wdyt?


Reply to this email directly or view it on GitHub.

@dengemann
Copy link
Member

@agramfort ... I don't find such a tag... and FIFF.FIFF_COMMENT is already used, as you implied. What about FIFF_DESCRIPTION?

@agramfort
Copy link
Member

I would try writing a FIFF_DESCRIPTION tag in the FIFFB_MNE_EVENTS block.

@dengemann
Copy link
Member

that's what i already prepared, let's see what it does ;-)

On 08.12.2012, at 14:50, Alexandre Gramfort notifications@github.com wrote:

I would try writing a FIFF_DESCRIPTION tag in the FIFFB_MNE_EVENTS block.


Reply to this email directly or view it on GitHub.

@dengemann
Copy link
Member

I issued WIP #243 to fully support saving and reading the event_id. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants