Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Transpose issue of CSP.plot_filters #8580

Merged
merged 2 commits into from Nov 29, 2020
Merged

FIX: Transpose issue of CSP.plot_filters #8580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7eb6c1f
Fix transpose issue of CSP.plot_filters
Nov 29, 2020
1740728
FIX: Transpose issue of CSP.plot_filters
Nov 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions doc/changes/latest.inc
View file
Open in desktop
Expand Up @@ -26,6 +26,8 @@ Current (0.22.dev0)

.. |Austin Hurst| replace:: **Austin Hurst**

.. |Hongjiang Ye| replace:: **Hongjiang Ye**


Enhancements
~~~~~~~~~~~~
Expand Down Expand Up @@ -78,6 +80,8 @@ Enhancements

Bugs
~~~~
- Fix a transpose issue of :func:`mne.decoding.CSP.plot_filters` (:gh:`8580` **by new contributor** |Hongjiang Ye|_)

- Fix :func:`mne.io.read_raw_curry` to deal with Curry datasets that have channels that are listed in the labels file, but which are absent from the saved data file (e.g. 'Ref' channel). Also now populates info['meas_date'] if possible (:gh:`8400` **by new contributor** |Tod Flak|_)

- Fix bug with mne.io.egi.tests/test_egi.py where it mandatorily downloaded testing data when it was not necessary (:gh:`8474` **by new contributor** |Aniket Pradhan|_)
Expand Down
2 changes: 2 additions & 0 deletions doc/changes/names.inc
View file
Open in desktop
Expand Up @@ -339,3 +339,5 @@
.. _Victoria Peterson: https://github.com/vpeterson

.. _Evan Hathaway: https://github.com/ephathaway

.. _Hongjiang Ye: https://github.com/rubyyhj
2 changes: 1 addition & 1 deletion mne/decoding/csp.py
View file
Open in desktop
Expand Up @@ -475,7 +475,7 @@ def plot_filters(self, info, components=None, ch_type=None,
info = cp.deepcopy(info)
info['sfreq'] = 1.
# create an evoked
filters = EvokedArray(self.filters_, info, tmin=0)
filters = EvokedArray(self.filters_.T, info, tmin=0)
# the call plot_topomap
return filters.plot_topomap(
times=components, ch_type=ch_type, vmin=vmin,
Expand Down