Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Transpose issue of CSP.plot_filters #8580

Merged
merged 2 commits into from Nov 29, 2020
Merged

FIX: Transpose issue of CSP.plot_filters #8580

merged 2 commits into from Nov 29, 2020

Conversation

rubyyhj
Copy link
Contributor

@rubyyhj rubyyhj commented Nov 29, 2020

Reference issue

Fixes #8579.

What does this implement/fix?

Just add a transpose to correct the CSP filters plot.

@rubyyhj rubyyhj mentioned this pull request Nov 29, 2020
Closed
cbrnr
cbrnr approved these changes Nov 29, 2020
View reviewed changes
Copy link
Contributor

@cbrnr cbrnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add a changelog entry and this is good to go!

@rubyyhj rubyyhj changed the title Fix transpose issue of CSP.plot_filters FIX: Transpose issue of CSP.plot_filters Nov 29, 2020
@rubyyhj rubyyhj requested a review from cbrnr November 29, 2020 18:26
@cbrnr cbrnr merged commit 34c944a into mne-tools:master Nov 29, 2020
2 checks passed
@cbrnr
Copy link
Contributor

cbrnr commented Nov 29, 2020

Thanks @rubyyhj!

@rubyyhj rubyyhj deleted the fix_csp_branch branch November 29, 2020 18:41
@rubyyhj rubyyhj restored the fix_csp_branch branch November 29, 2020 18:42
@rubyyhj rubyyhj deleted the fix_csp_branch branch November 29, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbrnr cbrnr cbrnr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSP.plot_filters() is actually plotting the transpose of filters
2 participants
@rubyyhj @cbrnr