Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX anon with IO round trip #8731

Merged
merged 3 commits into from Jan 12, 2021
Merged

FIX anon with IO round trip #8731

merged 3 commits into from Jan 12, 2021

Conversation

agramfort
Copy link
Member

closes #8661

@agramfort agramfort mentioned this pull request Jan 11, 2021
Closed
larsoner
larsoner reviewed Jan 11, 2021
View reviewed changes
mne/io/meas_info.py Outdated
@@ -2150,6 +2150,9 @@ def anonymize_info(info, daysback=None, keep_his=False, verbose=None):
# file_id and meas_id
for key in ('file_id', 'meas_id'):
value = info.get(key)
if (value['secs'], value['usecs']) == DATE_NONE:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conditional directly below this is either wrong (no need to check for non-None) or this line can fail (when value is None).

Perhaps the conditional 3 lines below should be modified instead, if none_meas_date or (value['sec'], value['usec]) == DATE_NONE:

@larsoner larsoner merged commit f394bbd into mne-tools:master Jan 12, 2021
@larsoner
Copy link
Member

Thanks @agramfort !

larsoner pushed a commit that referenced this pull request Jan 12, 2021
@agramfort @larsoner
FIX anon with IO round trip (#8731)
9791686 
* FIX anon with IO round trip

* update what's new

* better
cbrnr pushed a commit to cbrnr/mne-python that referenced this pull request Jan 15, 2021
@agramfort @cbrnr
FIX anon with IO round trip (mne-tools#8731)
86f4cdc 
* FIX anon with IO round trip

* update what's new

* better
larsoner added a commit to vpeterson/mne-python that referenced this pull request Feb 25, 2021
@larsoner
Merge remote-tracking branch 'upstream/master' into ssd_pipeline
7f9b58d 
* upstream/master: (66 commits)
  MRG, ENH: Add infant template downloader (mne-tools#8738)
  ENH: add reader for NeuroElectrics .nedf files (mne-tools#8734)
  DOC: improve glossary entry about fiducials (mne-tools#8763)
  MRG, ENH: Add Report.add_custom_css (mne-tools#8762)
  BUG, DOC: read_raw_egi didn't support pathlib.Path; update read_raw() docstring (mne-tools#8759)
  Add "dbs" as new channel type (mne-tools#8739)
  MRG, VIZ: Fix title position in plot_sensors (mne-tools#8752)
  MRG: Support for non-FIFF files in Report.parse_folder (mne-tools#8744)
  MRG, VIZ, FIX: sEEG picking in _prepare_topomap_plot() (mne-tools#8736)
  DOC: don't use single letter variable name in _compute_forward (mne-tools#8727)
  WIP: Fix search [skip github] [skip azp] (mne-tools#8742)
  WIP: Compare Beer-lambert to HOMER (mne-tools#8711)
  MRG: bump spyder version (mne-tools#8020)
  FIX anon with IO round trip (mne-tools#8731)
  fix set_bipolar_reference for Epochs (mne-tools#8728)
  WIP: Add width argument, reduce default (mne-tools#8725)
  ENH: Add toggle-all button to Report (mne-tools#8723)
  fix int/float conversion in nicolet header (mne-tools#8712)
  MRG, BUG: Fix Report.add_bem_to_section n_jobs != 1 (mne-tools#8713)
  MRG, DOC: Make "rank" options in docs more accessible (mne-tools#8707)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsoner larsoner larsoner left review comments

Assignees
No one assigned
Labels
backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

save changes file_id, causes anonymize to fail
2 participants
@agramfort @larsoner