Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Complete deprecations #9356

Merged
merged 7 commits into from Apr 28, 2021
Merged

API: Complete deprecations #9356

merged 7 commits into from Apr 28, 2021

Conversation

larsoner
Copy link
Member

Post-release deprecation changes.

@drammock
Copy link
Member

Here are a handful of XXX bits in our code that might(?) make sense to address now:

mne/channels/montage.py:683:    # XXX: to change to the new naming in v.0.20 (all this block should go)
mne/commands/mne_compute_proj_ecg.py:64:                      default=False)  # XXX: change to default=True in 0.17
mne/commands/mne_compute_proj_eog.py:68:                      default=False)  # XXX: change to default=True in 0.17
mne/fixes.py:32:    XXX: Can be removed when numpy introduces a fix.
mne/tests/test_annotations.py:65:    assert raw.annotations is not None  # XXX to be fixed in #5416
mne/tests/test_annotations.py:66:    assert len(raw.annotations.onset) == 0  # XXX to be fixed in #5416
mne/tests/test_annotations.py:250:    assert raw_read.annotations is not None  # XXX to be fixed in #5416
mne/tests/test_annotations.py:251:    assert len(raw_read.annotations.onset) == 0  # XXX to be fixed in #5416
mne/tests/test_cov.py:323:        # XXX don't use "shrunk" here, for some reason it makes Travis 2.7
mne/utils/docs.py:1892:"""  # XXX make sure we deal with this deprecation in 0.23
mne/viz/_brain/tests/test_brain.py:438:    # XXX disable for sprint because it's too unreliable
mne/viz/utils.py:993:    # XXX: Bug in matplotlib won't allow setting the position of existing
server_environment.yml:18:- nbformat <5.1  # XXX remove pinning once https://github.com/jupyter/nbformat/issues/206 has been fixed

@larsoner
Copy link
Member Author

Those comments probably just need to be updated, will look a bit more in-depth tomorrow

@larsoner
Copy link
Member Author

I'll take care of those in a separate PR so that it's easier to review

@larsoner larsoner merged commit 96fffbb into mne-tools:main Apr 28, 2021
@larsoner larsoner deleted the deps branch April 28, 2021 11:18
larsoner added a commit to agramfort/mne-python that referenced this pull request May 10, 2021
* upstream/main:
  FIX: make epoch cropping idempotent (mne-tools#9378)
  MRG, ENH: Add NIRSport support (mne-tools#9348)
  MRG, ENH: Make _get_hpi_info public (mne-tools#9369)
  ENH: Add a playback button to the notebook 3d backend (mne-tools#8741)
  better docs for permutation_cluster_test (mne-tools#9365)
  MRG: Add fNIRS to html output (mne-tools#9367)
  When plotting GFP comparison in Report, don't show sensor layout by default (mne-tools#9366)
  DOC: Update Mayavi troubleshooting section (mne-tools#9362)
  more tutorial tweaks (mne-tools#9359)
  MRG, MAINT: Use native GitHub Actions skip (mne-tools#9361)
  MAINT: Clean up crufty code [circle front] (mne-tools#9358)
  API: Complete deprecations (mne-tools#9356)
  Add qdarkstyle, darkdetect to environment.yml [circle full] (mne-tools#9357)
  FIX: Fix
  FIX: Add
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants