better docs for permutation_cluster_test #9365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
approved these changes
Apr 30, 2021
|
Doctest problem: https://github.com/mne-tools/mne-python/pull/9365/checks?check_run_id=2479764391#step:13:3306 adding a |
|
Thanks @drammock |
larsoner
added a commit
to rob-luke/mne-python
that referenced
this pull request
May 6, 2021
* upstream/main: MRG, ENH: Make _get_hpi_info public (mne-tools#9369) ENH: Add a playback button to the notebook 3d backend (mne-tools#8741) better docs for permutation_cluster_test (mne-tools#9365) MRG: Add fNIRS to html output (mne-tools#9367) When plotting GFP comparison in Report, don't show sensor layout by default (mne-tools#9366) DOC: Update Mayavi troubleshooting section (mne-tools#9362) more tutorial tweaks (mne-tools#9359)
larsoner
added a commit
to agramfort/mne-python
that referenced
this pull request
May 10, 2021
* upstream/main: FIX: make epoch cropping idempotent (mne-tools#9378) MRG, ENH: Add NIRSport support (mne-tools#9348) MRG, ENH: Make _get_hpi_info public (mne-tools#9369) ENH: Add a playback button to the notebook 3d backend (mne-tools#8741) better docs for permutation_cluster_test (mne-tools#9365) MRG: Add fNIRS to html output (mne-tools#9367) When plotting GFP comparison in Report, don't show sensor layout by default (mne-tools#9366) DOC: Update Mayavi troubleshooting section (mne-tools#9362) more tutorial tweaks (mne-tools#9359) MRG, MAINT: Use native GitHub Actions skip (mne-tools#9361) MAINT: Clean up crufty code [circle front] (mne-tools#9358) API: Complete deprecations (mne-tools#9356) Add qdarkstyle, darkdetect to environment.yml [circle full] (mne-tools#9357) FIX: Fix FIX: Add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9364
@larsoner following up on our conversation today, this should clarify the docstring at least. I also snuck in a code simplification, though I realized that the functionality for omitting adjacency along a particular dimension is already there, you just need to pass a matrix of zeros for that dimension.