Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: Add fNIRS to html output #9367

Merged
merged 3 commits into from May 2, 2021
Merged

MRG: Add fNIRS to html output #9367

merged 3 commits into from May 2, 2021

Conversation

rob-luke
Copy link
Member

@rob-luke rob-luke commented May 2, 2021

Reference issue

None. But I really love these html outputs in notebooks, so cool.

What does this implement/fix?

Add fNIRS to the html output for raw.

Additional information

I follow #9172, but am unsure how to test this change. Can we merge without a test?

Alternative solution

If you don't want to add fNIRS channels as they are less common we could have an optional row using:

    {{if n_fnirs > 0}}
        <th>fNIRS channels</th>
        <td>{{n_fnirs}}</td>
    {{endif}}

I tested this locally and it works too, I could do the same for EOG and ECG too if you want.

@rob-luke
Copy link
Member Author

rob-luke commented May 2, 2021

@rob-luke rob-luke changed the title WIP: Add fNIRS to html output MRG: Add fNIRS to html output May 2, 2021
@rob-luke
Copy link
Member Author

rob-luke commented May 2, 2021

@larsoner @drammock @agramfort are you ok with this or would you prefer my alternative option above?

@agramfort agramfort merged commit cb3c34f into mne-tools:main May 2, 2021
@agramfort
Copy link
Member

thx @rob-luke

@rob-luke rob-luke deleted the nirshtml branch May 2, 2021 19:38
larsoner added a commit to rob-luke/mne-python that referenced this pull request May 6, 2021
* upstream/main:
  MRG, ENH: Make _get_hpi_info public (mne-tools#9369)
  ENH: Add a playback button to the notebook 3d backend (mne-tools#8741)
  better docs for permutation_cluster_test (mne-tools#9365)
  MRG: Add fNIRS to html output (mne-tools#9367)
  When plotting GFP comparison in Report, don't show sensor layout by default (mne-tools#9366)
  DOC: Update Mayavi troubleshooting section (mne-tools#9362)
  more tutorial tweaks (mne-tools#9359)
larsoner added a commit to agramfort/mne-python that referenced this pull request May 10, 2021
* upstream/main:
  FIX: make epoch cropping idempotent (mne-tools#9378)
  MRG, ENH: Add NIRSport support (mne-tools#9348)
  MRG, ENH: Make _get_hpi_info public (mne-tools#9369)
  ENH: Add a playback button to the notebook 3d backend (mne-tools#8741)
  better docs for permutation_cluster_test (mne-tools#9365)
  MRG: Add fNIRS to html output (mne-tools#9367)
  When plotting GFP comparison in Report, don't show sensor layout by default (mne-tools#9366)
  DOC: Update Mayavi troubleshooting section (mne-tools#9362)
  more tutorial tweaks (mne-tools#9359)
  MRG, MAINT: Use native GitHub Actions skip (mne-tools#9361)
  MAINT: Clean up crufty code [circle front] (mne-tools#9358)
  API: Complete deprecations (mne-tools#9356)
  Add qdarkstyle, darkdetect to environment.yml [circle full] (mne-tools#9357)
  FIX: Fix
  FIX: Add
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants