Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Github (except translations) #1

Closed
25 of 26 tasks
jmehne opened this issue Oct 18, 2017 · 11 comments
Closed
25 of 26 tasks

Migration to Github (except translations) #1

jmehne opened this issue Oct 18, 2017 · 11 comments
Assignees
Labels

Comments

@jmehne
Copy link
Contributor

jmehne commented Oct 18, 2017

Relevant ML threads: recent, last year
Before migration:

  • Test integration with launchpad's translation service
    • Problem: qastaging.launchpad.net and staging.launchpad.net don't import the branch properly. Which is not surprising, because they don't really work to begin with. But the import works fine here, so I don't think it will be a problem. Marking as solved.
  • Run tests on Windows automatically with Appveyor
    • Initial setup
    • Fix for latex on windows: install miktex.portable with chocolatey and cache it
    • Fix test hang. (Reason: running dvipng resulted in the miktex installer being triggered, because zhmetrics wasn't installed.)
    • Optional: find out how to install zhmetrics from local file. Can be done, but package is only 35kB bit, so not worth it.
    • Find out reason for excessive test failures
  • Create a top-level README.md file
  • Prepare website udpate, but don't update the website yet (see website_update.md):
    • Bug reporting on Github
    • Hacking: Github + git workflow
    • Translation on launchpad

Steps immediately before conversion:

  • Create Pull Request on launchpad for changes that I've accumulated in the github branch here on Github
    • Wait until the (revised) pull request is merged
  • Ask Peter to merge his experimental branch into Launchpad master
  • Optional, but nice: Make tests work

Actual conversion:

  • Convert bzr -> git using the steps outlined in my email (don't forget to remove the additional file mentioned by Peter)
  • Push the converted, new 'productive' repository to Github
  • Update the launchpad page:
    • Close bug tracker
    • Migrate open bug reports
    • Switch translation service to git -> bzr import from Github
    • Optional: create a git mirror on Launchpad
    • Update description: only used for translation, please report bugs and get the code on Github (link)
  • Update website with the pre-prepared changes.
  • Update project description here on Github to reflect that it is the main repository.
@jmehne jmehne changed the title Conversion to Github Migration to Github (except translations) Oct 18, 2017
@jmehne jmehne self-assigned this Oct 18, 2017
@pbienst
Copy link
Contributor

pbienst commented Oct 30, 2017

Almost there, main thing left is the translation infrastructure.

@jmehne
Copy link
Contributor Author

jmehne commented Oct 30, 2017

Okay, first things first, I created a copy of the trunk branch on launchpad as a backup.

Now, we need to replace the current trunk branch on launchpad with a new one that is imported from Github into a bzr branch on launchpad. The import process will take some time, but once it is done the translations infrastructure should pick up the branch just fine.

You can either give me admin rights an launchpad (jmehne), or do it yourself. If you are on the code page on launchpad there should be a 'configure code' button (that's at least what I see in the staging area). Then, choose bzr, import code frome somwhere else, branch name is master, the url is https://github.com/mnemosyne-proj/mnemosyne.git, branch owner should be mnemosyne-project.

@pbienst
Copy link
Contributor

pbienst commented Oct 30, 2017

I assume it's importing now...

@jmehne
Copy link
Contributor Author

jmehne commented Oct 30, 2017

Urgh, launchpad chokes on the gpgsig field of the most recent merge commit. Seems to be this unsolved bug. I guess Github automatically adds that if you have a gpg key imported into your account ...

@jmehne
Copy link
Contributor Author

jmehne commented Oct 30, 2017

Hm, let me remove the gpgsig field in that commit and force-push to the repository. Let's see if that fixes the import and if the translations then work correctly.

Then, we need to check how to make Github not write the gpgsig field.

@pbienst
Copy link
Contributor

pbienst commented Oct 30, 2017

BTW, I also added you to the mnemosyne-proj devel group on Launchpad, so that you have admin access.

@jmehne
Copy link
Contributor Author

jmehne commented Oct 30, 2017

Thanks!

Okay, the import into launchpad as a bzr repository was successful.

It seems to me that the translations infrastructure is automatically tracking the correct branch, but I'm not a 100% sure if it works. Can you try and create a change that should be picked up so we can test it? I don't quite understand the workflow to do that.

@pbienst
Copy link
Contributor

pbienst commented Oct 30, 2017

Made a trivial commit. Tomorrow, the following string should appear on Launchpad, which we can try to translate: "TRANSLATION TEST"

@jmehne
Copy link
Contributor Author

jmehne commented Oct 30, 2017

It works already! The file is being marked as imported in the translation infrastructure and I could translate the string.

@pbienst
Copy link
Contributor

pbienst commented Oct 30, 2017

Cool! I guess this completes the switch and we can close this issue then.

@jmehne
Copy link
Contributor Author

jmehne commented Oct 30, 2017

Perfect! Sometime this week, I will look into the windows test failure on Python 3.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants