Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest blockly version: goog is not defined #36

Closed
greyivy opened this issue Oct 16, 2019 · 4 comments
Closed

Latest blockly version: goog is not defined #36

greyivy opened this issue Oct 16, 2019 · 4 comments

Comments

@greyivy
Copy link

greyivy commented Oct 16, 2019

When trying to use this package with the latest version of blockly, I get the following error (via test and server use):

ReferenceError: goog is not defined

@greyivy
Copy link
Author

greyivy commented Oct 16, 2019

This seems to have fixed it, although I'm not sure if it has the potential to break anything:
https://github.com/greyivy/node-blockly/commit/ad63265fd5723f2ecefbe5c26da255264490c3f2

@mo4islona
Copy link
Owner

Could you provide code that produce such error?

@greyivy
Copy link
Author

greyivy commented Oct 17, 2019

The included test (via npm test) should produce it if Blockly is upgraded.

@mo4islona
Copy link
Owner

Thanks! It works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants